Re: [PATCH v3 06/10] run-command: don't die in child when duping /dev/null

On 04/14, Eric Wong wrote: > Brandon Williams wrote: > > + if (cmd->no_stdin || cmd->no_stdout || cmd->no_stderr) { > > + null_fd = open("/dev/null", O_RDWR | O_CLOEXEC | O_NONBLOCK); > > O_NONBLOCK? This was in my original patch, too :x > Wow, I wonder what I was smoking that day...

Re: [PATCH v3 06/10] run-command: don't die in child when duping /dev/null

Brandon Williams wrote: > + if (cmd->no_stdin || cmd->no_stdout || cmd->no_stderr) { > + null_fd = open("/dev/null", O_RDWR | O_CLOEXEC | O_NONBLOCK); O_NONBLOCK? This was in my original patch, too :x Wow, I wonder what I was smoking that day...

[PATCH v3 06/10] run-command: don't die in child when duping /dev/null

Signed-off-by: Brandon Williams --- run-command.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/run-command.c b/run-command.c index 5864b5ff3..ee2c680ab 100644 --- a/run-command.c +++ b/run-command.c @@ -117,18 +117,6 @@ static inline void clos