Re: [PATCH v3 05/13] config.mak.uname: set FREAD_READS_DIRECTORIES for Darwin, too

2017-05-30 Thread Stefan Beller
On Tue, May 30, 2017 at 4:14 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Thu, May 25, 2017 at 8:35 PM, Junio C Hamano wrote: >> >> Do we have any reasons for that, or pointers on the mailing list, that this >> is a good idea or needed? Does it fix a bug or enable a new feature on

Re: [PATCH v3 05/13] config.mak.uname: set FREAD_READS_DIRECTORIES for Darwin, too

2017-05-30 Thread Junio C Hamano
Stefan Beller writes: > On Thu, May 25, 2017 at 8:35 PM, Junio C Hamano wrote: > > Do we have any reasons for that, or pointers on the mailing list, that this > is a good idea or needed? Does it fix a bug or enable a new feature on Darwin? BSD lets you open() a directory for reading and hence w

Re: [PATCH v3 05/13] config.mak.uname: set FREAD_READS_DIRECTORIES for Darwin, too

2017-05-30 Thread Stefan Beller
On Thu, May 25, 2017 at 8:35 PM, Junio C Hamano wrote: Do we have any reasons for that, or pointers on the mailing list, that this is a good idea or needed? Does it fix a bug or enable a new feature on Darwin? > Signed-off-by: Junio C Hamano > --- > config.mak.uname | 1 + > 1 file changed, 1

[PATCH v3 05/13] config.mak.uname: set FREAD_READS_DIRECTORIES for Darwin, too

2017-05-25 Thread Junio C Hamano
Signed-off-by: Junio C Hamano --- config.mak.uname | 1 + 1 file changed, 1 insertion(+) diff --git a/config.mak.uname b/config.mak.uname index a25ffddb3e..1743890164 100644 --- a/config.mak.uname +++ b/config.mak.uname @@ -110,6 +110,7 @@ ifeq ($(uname_S),Darwin) BASIC_CFLAGS += -DPRECO