Re: [PATCH v3 02/11] Add initial support for many promisor remotes

On Wed, Mar 13, 2019 at 5:09 AM Junio C Hamano wrote: > > Christian Couder writes: > > > +struct promisor_remote *promisor_remote_new(const char *remote_name) > > +{ > > Shouldn't this be static? The config callback that calls this > function is inside this file. Yeah, I made it static. > > +

Re: [PATCH v3 02/11] Add initial support for many promisor remotes

Junio C Hamano writes: > What is the rule for these promisor names? Disregard this part (and only this part). The values are not names, but just "is this thing a promisor" boolean.

Re: [PATCH v3 02/11] Add initial support for many promisor remotes

Christian Couder writes: > +struct promisor_remote *promisor_remote_new(const char *remote_name) > +{ Shouldn't this be static? The config callback that calls this function is inside this file. > + struct promisor_remote *o; > + > + o = xcalloc(1, sizeof(*o)); > + o->remote_name =

[PATCH v3 02/11] Add initial support for many promisor remotes

From: Christian Couder The promisor-remote.{c,h} files will contain functions to manage many promisor remotes. We expect that there will not be a lot of promisor remotes, so it is ok to use a simple linked list to manage them. Helped-by: Jeff King Signed-off-by: Christian Couder --- Makefile