Re: [PATCH v3 02/10] submodule status: use submodule--helper is-active

2017-03-14 Thread Brandon Williams
On 03/14, Brandon Williams wrote: > On 03/14, Junio C Hamano wrote: > > Brandon Williams writes: > > > > > Signed-off-by: Brandon Williams > > > --- > > > git-submodule.sh | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/git-submodule.sh b/git-submodule.sh

Re: [PATCH v3 02/10] submodule status: use submodule--helper is-active

2017-03-14 Thread Brandon Williams
On 03/14, Junio C Hamano wrote: > Brandon Williams writes: > > > Signed-off-by: Brandon Williams > > --- > > git-submodule.sh | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/git-submodule.sh b/git-submodule.sh > > index 136e26a2c..ab233712d 100755 > > --- a/git-

Re: [PATCH v3 02/10] submodule status: use submodule--helper is-active

2017-03-14 Thread Junio C Hamano
Stefan Beller writes: > So to answer your original question, I think the codebase currently > thinks by_path is handier, the name is a mere internal field in > "struct submodule", useful for looking up its git dir. OK, that makes sense at the conceptual level, too. When you have a specific vers

Re: [PATCH v3 02/10] submodule status: use submodule--helper is-active

2017-03-14 Thread Junio C Hamano
Stefan Beller writes: > There we take the path as name and if a real name exists, the name > is overwritten with the real name, i.e. > > name = name_for_path(path) ? name_for_path(path) : path; > > which IMHO is overly accepting and we should just die in case of > !name_for_path. Yes, I agre

Re: [PATCH v3 02/10] submodule status: use submodule--helper is-active

2017-03-14 Thread Stefan Beller
On Tue, Mar 14, 2017 at 10:46 AM, Junio C Hamano wrote: > Brandon Williams writes: > >> Signed-off-by: Brandon Williams >> --- >> git-submodule.sh | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/git-submodule.sh b/git-submodule.sh >> index 136e26a2c..ab233712d 1007

Re: [PATCH v3 02/10] submodule status: use submodule--helper is-active

2017-03-14 Thread Junio C Hamano
Brandon Williams writes: > Signed-off-by: Brandon Williams > --- > git-submodule.sh | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/git-submodule.sh b/git-submodule.sh > index 136e26a2c..ab233712d 100755 > --- a/git-submodule.sh > +++ b/git-submodule.sh > @@ -1010,14

[PATCH v3 02/10] submodule status: use submodule--helper is-active

2017-03-13 Thread Brandon Williams
Signed-off-by: Brandon Williams --- git-submodule.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index 136e26a2c..ab233712d 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -1010,14 +1010,13 @@ cmd_status() do