Re: [PATCH v3 01/25] mingw: avoid memory leak when splitting PATH

2017-05-04 Thread Johannes Schindelin
Hi René, On Wed, 3 May 2017, René Scharfe wrote: > Am 02.05.2017 um 18:00 schrieb Johannes Schindelin: > > In the (admittedly, concocted) case that PATH consists only of colons, we > > would leak the duplicated string. > > Nit: It's about semicolons, right? At least that's what get_path_split >

Re: [PATCH v3 01/25] mingw: avoid memory leak when splitting PATH

2017-05-03 Thread René Scharfe
Am 02.05.2017 um 18:00 schrieb Johannes Schindelin: In the (admittedly, concocted) case that PATH consists only of colons, we would leak the duplicated string. Nit: It's about semicolons, right? At least that's what get_path_split is searching for. Or is there some kind of translation going o

[PATCH v3 01/25] mingw: avoid memory leak when splitting PATH

2017-05-02 Thread Johannes Schindelin
In the (admittedly, concocted) case that PATH consists only of colons, we would leak the duplicated string. Signed-off-by: Johannes Schindelin --- compat/mingw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/compat/mingw.c b/compat/mingw.c index 3fbfda5978b..fe0e3ccd248