Re: [PATCH v3 01/10] pkt-line: extract set_packet_header()

2016-08-05 Thread Lars Schneider
> On 03 Aug 2016, at 22:05, Jakub Narębski wrote: > > [This response might have been invalidated by v4] > > W dniu 01.08.2016 o 13:33, Lars Schneider pisze: >>> On 30 Jul 2016, at 12:30, Jakub Narębski wrote: > #define hex(a) (hexchar[(a) & 15]) >>> >>> I guess that this is inherited f

Re: [PATCH v3 01/10] pkt-line: extract set_packet_header()

2016-08-03 Thread Jakub Narębski
[This response might have been invalidated by v4] W dniu 01.08.2016 o 13:33, Lars Schneider pisze: >> On 30 Jul 2016, at 12:30, Jakub Narębski wrote: >>> #define hex(a) (hexchar[(a) & 15]) >> >> I guess that this is inherited from the original, but this preprocessor >> macro is local to the for

Re: [PATCH v3 01/10] pkt-line: extract set_packet_header()

2016-08-01 Thread Lars Schneider
> On 30 Jul 2016, at 12:30, Jakub Narębski wrote: > > W dniu 30.07.2016 o 01:37, larsxschnei...@gmail.com pisze: >> From: Lars Schneider >> >> set_packet_header() converts an integer to a 4 byte hex string. Make >> this function locally available so that other pkt-line functions can >> use it.

Re: [PATCH v3 01/10] pkt-line: extract set_packet_header()

2016-07-30 Thread Jakub Narębski
W dniu 30.07.2016 o 01:37, larsxschnei...@gmail.com pisze: > From: Lars Schneider > > set_packet_header() converts an integer to a 4 byte hex string. Make > this function locally available so that other pkt-line functions can > use it. This description is not that clear that set_packet_header()

[PATCH v3 01/10] pkt-line: extract set_packet_header()

2016-07-29 Thread larsxschneider
From: Lars Schneider set_packet_header() converts an integer to a 4 byte hex string. Make this function locally available so that other pkt-line functions can use it. Signed-off-by: Lars Schneider --- pkt-line.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git