Re: [PATCH v3 00/56] Convert parts of refs.c to struct object_id

2015-05-26 Thread Junio C Hamano
"brian m. carlson" writes: > If Junio would like to add my sign-off to the end, he's welcome to do > so: > > Signed-off-by: brian m. carlson Heh, too late. Thanks for explaining the true flow of patches, though. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of

Re: [PATCH v3 00/56] Convert parts of refs.c to struct object_id

2015-05-26 Thread brian m. carlson
On Tue, May 26, 2015 at 10:37:29AM -0700, Stefan Beller wrote: > On Mon, May 25, 2015 at 12:40 PM, brian m. carlson > wrote: > > On Mon, May 25, 2015 at 12:34:59PM -0700, Junio C Hamano wrote: > >> [PATCH 01/56] was authored by you but has Michael's sign-off, which > >> looked somewhat odd to me,

Re: [PATCH v3 00/56] Convert parts of refs.c to struct object_id

2015-05-26 Thread Stefan Beller
On Mon, May 25, 2015 at 12:40 PM, brian m. carlson wrote: > On Mon, May 25, 2015 at 12:34:59PM -0700, Junio C Hamano wrote: >> [PATCH 01/56] was authored by you but has Michael's sign-off, which >> looked somewhat odd to me, though. > > Yes, it does. He picked it up from me, and signed off, and I

Re: [PATCH v3 00/56] Convert parts of refs.c to struct object_id

2015-05-25 Thread brian m. carlson
On Mon, May 25, 2015 at 12:34:59PM -0700, Junio C Hamano wrote: > [PATCH 01/56] was authored by you but has Michael's sign-off, which > looked somewhat odd to me, though. Yes, it does. He picked it up from me, and signed off, and I took his branch. I don't believe he changed it, but I didn't che

Re: [PATCH v3 00/56] Convert parts of refs.c to struct object_id

2015-05-25 Thread Junio C Hamano
"brian m. carlson" writes: > Changes from v2: > * Adopt Michael Haggerty's patch series that uses an adapter function. > * Squash some of these patches together where it makes sense in order to > reduce the quantity of patches. > > This does only slightly more than my original series, just in a

[PATCH v3 00/56] Convert parts of refs.c to struct object_id

2015-05-25 Thread brian m. carlson
This is a conversion of parts of refs.c to use struct object_id. refs.c, and the for_each_ref series of functions explicitly, is the source for many instances of object IDs in the codebase. Therefore, it makes sense to convert this series of functions to provide a basis for further conversions.