Re: [PATCH v3 00/20] hashmap bug/safety/ease-of-use fixes

2019-10-08 Thread Junio C Hamano
Derrick Stolee writes: > On 10/6/2019 7:30 PM, Eric Wong wrote: >> v3 changes: >> - use __typeof__ to avoid invalid clang warning on uninitialized var >> - formatting fixes recommended by Stolee >> - add Reviewed-by for Stolee >> - add patch 20 to update docs to drop first member requirement >>

Re: [PATCH v3 00/20] hashmap bug/safety/ease-of-use fixes

2019-10-08 Thread Derrick Stolee
On 10/6/2019 7:30 PM, Eric Wong wrote: > v3 changes: > - use __typeof__ to avoid invalid clang warning on uninitialized var > - formatting fixes recommended by Stolee > - add Reviewed-by for Stolee > - add patch 20 to update docs to drop first member requirement > > Range-diff against v2: I scann

Re: [PATCH v3 00/20] hashmap bug/safety/ease-of-use fixes

2019-10-08 Thread Derrick Stolee
On 10/8/2019 4:58 AM, Johannes Schindelin wrote: > Hi Eric & Junio, > > On Sun, 6 Oct 2019, Eric Wong wrote: > >> v3 changes: >> - use __typeof__ to avoid invalid clang warning on uninitialized var >> - formatting fixes recommended by Stolee >> - add Reviewed-by for Stolee >> - add patch 20 to up

Re: [PATCH v3 00/20] hashmap bug/safety/ease-of-use fixes

2019-10-08 Thread Johannes Schindelin
Hi Eric & Junio, On Sun, 6 Oct 2019, Eric Wong wrote: > v3 changes: > - use __typeof__ to avoid invalid clang warning on uninitialized var > - formatting fixes recommended by Stolee > - add Reviewed-by for Stolee > - add patch 20 to update docs to drop first member requirement This has quite a b

Re: [PATCH v3 00/20] hashmap bug/safety/ease-of-use fixes

2019-10-06 Thread Junio C Hamano
Eric Wong writes: > v3 changes: > - use __typeof__ to avoid invalid clang warning on uninitialized var > - formatting fixes recommended by Stolee > - add Reviewed-by for Stolee > - add patch 20 to update docs to drop first member requirement I just did git checkout ew/hashmap gi

[PATCH v3 00/20] hashmap bug/safety/ease-of-use fixes

2019-10-06 Thread Eric Wong
v3 changes: - use __typeof__ to avoid invalid clang warning on uninitialized var - formatting fixes recommended by Stolee - add Reviewed-by for Stolee - add patch 20 to update docs to drop first member requirement v2 here: https://public-inbox.org/git/20190924010324.22619-...@80x24.org/ The fol