Re: [PATCH v3 00/19] new git check-ignore sub-command

2012-12-28 Thread Junio C Hamano
Antoine Pelisse writes: > I think they will interact, but I need to have a deeper look to Adam's series. > If it does, do you want me to base my work on the top of his branch ? Not necessarily. If it becomes absolutely necessary to introduce patch dependencies, I would rather see an addition of

Re: [PATCH v3 00/19] new git check-ignore sub-command

2012-12-28 Thread Junio C Hamano
After skimming the series twice quickly, I found that the early part of refactorings are excellently done. Making existing private functions into public needs a lot more careful thought on namings, I think, though. The end result looks promising. Thanks for a pleasant read. -- To unsubscribe fro

Re: [PATCH v3 00/19] new git check-ignore sub-command

2012-12-28 Thread Antoine Pelisse
I think they will interact, but I need to have a deeper look to Adam's series. If it does, do you want me to base my work on the top of his branch ? On Fri, Dec 28, 2012 at 8:39 PM, Adam Spiers wrote: > On Fri, Dec 28, 2012 at 6:50 PM, Junio C Hamano wrote: >> Adam Spiers writes: >> >>> This v3

Re: [PATCH v3 00/19] new git check-ignore sub-command

2012-12-28 Thread Adam Spiers
On Fri, Dec 28, 2012 at 6:50 PM, Junio C Hamano wrote: > Adam Spiers writes: > >> This v3 re-roll of my check-ignore series is a reasonably substantial >> revamp over v2, and applies on top of Junio's current >> nd/attr-match-optim-more branch (82dce998c202). > > Thanks. > > Does this (and should

Re: [PATCH v3 00/19] new git check-ignore sub-command

2012-12-28 Thread Junio C Hamano
Adam Spiers writes: > This v3 re-roll of my check-ignore series is a reasonably substantial > revamp over v2, and applies on top of Junio's current > nd/attr-match-optim-more branch (82dce998c202). Thanks. Does this (and should this, if it doesn't) interact with the more recent discussion aroun

Re: [PATCH v3 00/19] new git check-ignore sub-command

2012-12-26 Thread Michael Leal
Adam Spiers adamspiers.org> writes: > > This v3 re-roll of my check- ignore series is a reasonably substantial > revamp over v2, and applies on top of Junio's current > nd/attr-match-optim-more branch (82dce998c202). > > All feedback and patches from the v2 series has been incorporated, a

[PATCH v3 00/19] new git check-ignore sub-command

2012-12-26 Thread Adam Spiers
This v3 re-roll of my check-ignore series is a reasonably substantial revamp over v2, and applies on top of Junio's current nd/attr-match-optim-more branch (82dce998c202). All feedback and patches from the v2 series has been incorporated, and several other improvements too, including: - composi