Jeff Hostetler writes:
> On 1/31/2019 2:45 PM, Jeff Hostetler wrote:
>>
> ...
>>
>> I can undo my formatting changes if we want to update the settings.
>> I'll give that a try if there are no objections.
>>
>
> I'll push up a V5 in the morning that adds the foreach
> macros to the .clang-format a
On 1/31/2019 2:45 PM, Jeff Hostetler wrote:
...
I can undo my formatting changes if we want to update the settings.
I'll give that a try if there are no objections.
I'll push up a V5 in the morning that adds the foreach
macros to the .clang-format and updates the code accordingly.
Curre
On 1/31/2019 1:51 PM, Junio C Hamano wrote:
Jeff Hostetler writes:
-+ for_each_builtin(j, tgt_j) {
++ for_each_builtin(j, tgt_j)
++ {
+ tgt_j->pfn_term();
+ }
Our CodingGuidelines prefer the opening brace on the sa
Jeff Hostetler writes:
>>> -+for_each_builtin(j, tgt_j) {
>>> ++for_each_builtin(j, tgt_j)
>>> ++{
>>>+tgt_j->pfn_term();
>>>+}
>>
>> Our CodingGuidelines prefer the opening brace on the same line after
>> the if/for/while/struct/etc.
On 1/31/2019 9:38 AM, SZEDER Gábor wrote:
On Wed, Jan 30, 2019 at 11:51:04AM -0800, Jeff Hostetler via GitGitGadget wrote:
V3 addresses:
[] incorporate most of the suggestions from clang-format.
Range-diff vs v2:
1: 1a90de9dab < -: -- trace2:
Documentation/technical/api-tra
On Wed, Jan 30, 2019 at 11:51:04AM -0800, Jeff Hostetler via GitGitGadget wrote:
> V3 addresses:
> [] incorporate most of the suggestions from clang-format.
> Range-diff vs v2:
>
> 1: 1a90de9dab < -: -- trace2:
> Documentation/technical/api-trace2.txt
> -: -- > 1: 60b56
V3 addresses: [] re-fix the trace2 tests using an inline environment
variable rather than exporting and unsetting. [] overhaul the design
document to include prototype declarations and more file format information.
[] incorporate most of the suggestions from clang-format. [] add ability to
trace to
7 matches
Mail list logo
