Re: [PATCH v3 00/11] unify appending of sob

2013-01-31 Thread Brandon Casey
On Wed, Jan 30, 2013 at 9:37 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Jonathan Nieder writes: >> >>> Brandon Casey wrote: >>> Round 3. >>> >>> Thanks for a pleasant read. My only remaining observations are >>> cosmetic, except for a portability question in Duy's test script,

Re: [PATCH v3 00/11] unify appending of sob

2013-01-30 Thread Junio C Hamano
Junio C Hamano writes: > Jonathan Nieder writes: > >> Brandon Casey wrote: >> >>> Round 3. >> >> Thanks for a pleasant read. My only remaining observations are >> cosmetic, except for a portability question in Duy's test script, a >> small behavior change when the commit message ends with an >>

Re: [PATCH v3 00/11] unify appending of sob

2013-01-27 Thread Junio C Hamano
Jonathan Nieder writes: > Brandon Casey wrote: > >> Round 3. > > Thanks for a pleasant read. My only remaining observations are > cosmetic, except for a portability question in Duy's test script, a > small behavior change when the commit message ends with an > RFC2822-style header with no traili

Re: [PATCH v3 00/11] unify appending of sob

2013-01-27 Thread Jonathan Nieder
Brandon Casey wrote: > Round 3. Thanks for a pleasant read. My only remaining observations are cosmetic, except for a portability question in Duy's test script, a small behavior change when the commit message ends with an RFC2822-style header with no trailing newline and the possibility of tight

[PATCH v3 00/11] unify appending of sob

2013-01-27 Thread Brandon Casey
Round 3. -Brandon Brandon Casey (9): sequencer.c: rework search for start of footer to improve clarity commit, cherry-pick -s: remove broken support for multiline rfc2822 fields t/test-lib-functions.sh: allow to specify the tag name to test_commit t/t3511: add some tests of 'cherry-pi