Re: [PATCH v3 0/4] Makefile: run coccicheck on all non-upstream sources

2019-09-17 Thread Junio C Hamano
SZEDER Gábor writes: > On Mon, Sep 16, 2019 at 01:57:14PM -0700, Junio C Hamano wrote: >> Queued; thanks. > > Nit: it would be nicer to queue this series on top of > 'dl/compat-cleanup', because 'make coccicheck' errors out suggesting > transformations in 'compat/mingw.c' that have only been appl

Re: [PATCH v3 0/4] Makefile: run coccicheck on all non-upstream sources

2019-09-17 Thread SZEDER Gábor
On Mon, Sep 16, 2019 at 01:57:14PM -0700, Junio C Hamano wrote: > Queued; thanks. Nit: it would be nicer to queue this series on top of 'dl/compat-cleanup', because 'make coccicheck' errors out suggesting transformations in 'compat/mingw.c' that have only been applied in that series.

Re: [PATCH v3 0/4] Makefile: run coccicheck on all non-upstream sources

2019-09-16 Thread Junio C Hamano
Queued; thanks.

[PATCH v3 0/4] Makefile: run coccicheck on all non-upstream sources

2019-09-16 Thread Denton Liu
Hi all, I spent the weekend brooding over this and I opted to not convert $(FIND_SOURCE_FILES) into a list of filenames. I put the justification for it in 4/4 so, hopefully, it'll make sense for someone who might want to do the same change in the future. Before, when we ran coccicheck, it would o