Re: [PATCH v3 0/4] Delete ignore_env member in struct repository

2018-02-28 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > v3 fixes comment style. Also since Brandon raised a question about > shared_root, it's obviously not a good name, so I renamed it to > commondir. > > I still keep the delete patch 2/4, but I move the repo_setup_env() > deletion back to 1/4 so all env logic is in on

Re: [PATCH v3 0/4] Delete ignore_env member in struct repository

2018-02-28 Thread Brandon Williams
On 02/28, Nguyễn Thái Ngọc Duy wrote: > v3 fixes comment style. Also since Brandon raised a question about > shared_root, it's obviously not a good name, so I renamed it to > commondir. Thanks, its a bit clearer and more consistent with the rest of the terminology we already have :) > > I still

[PATCH v3 0/4] Delete ignore_env member in struct repository

2018-02-27 Thread Nguyễn Thái Ngọc Duy
v3 fixes comment style. Also since Brandon raised a question about shared_root, it's obviously not a good name, so I renamed it to commondir. I still keep the delete patch 2/4, but I move the repo_setup_env() deletion back to 1/4 so all env logic is in one patch (the introduction of new helper fun