Re: [PATCH v3] userdiff: add built-in pattern for rust

2019-05-28 Thread Marc-André Lureau
Hi Johannes On Tue, May 28, 2019 at 10:31 PM Johannes Sixt wrote: > > Am 28.05.19 um 18:34 schrieb Junio C Hamano: > > Marc-André Lureau writes: > > > >> Ok, I am adding: > >> ... > >> sure, I thought it was already covered. > >> ... > >> I think that would be fine, ok I am changing it > > > > T

Re: [PATCH v3] userdiff: add built-in pattern for rust

2019-05-28 Thread Johannes Sixt
Am 28.05.19 um 18:34 schrieb Junio C Hamano: > Marc-André Lureau writes: > >> Ok, I am adding: >> ... >> sure, I thought it was already covered. >> ... >> I think that would be fine, ok I am changing it > > Thanks, both. > > The previous round has already hit 'next' (which means that we won't >

Re: [PATCH v3] userdiff: add built-in pattern for rust

2019-05-28 Thread Junio C Hamano
Marc-André Lureau writes: > Ok, I am adding: > ... > sure, I thought it was already covered. > ... > I think that would be fine, ok I am changing it Thanks, both. The previous round has already hit 'next' (which means that we won't replacing the patch wholesale), so whatever you do, please make

Re: [PATCH v3] userdiff: add built-in pattern for rust

2019-05-21 Thread Marc-André Lureau
Hi On Mon, May 20, 2019 at 9:52 PM Johannes Sixt wrote: > > Am 20.05.19 um 19:04 schrieb marcandre.lur...@redhat.com: > > From: Marc-André Lureau > > > > This adds xfuncname and word_regex patterns for Rust, a quite > > popular programming language. It also includes test cases for the > > xfuncn

Re: [PATCH v3] userdiff: add built-in pattern for rust

2019-05-20 Thread Johannes Sixt
Am 20.05.19 um 19:04 schrieb marcandre.lur...@redhat.com: > From: Marc-André Lureau > > This adds xfuncname and word_regex patterns for Rust, a quite > popular programming language. It also includes test cases for the > xfuncname regex (t4018) and updated documentation. > > The word_regex patter

[PATCH v3] userdiff: add built-in pattern for rust

2019-05-20 Thread marcandre . lureau
From: Marc-André Lureau This adds xfuncname and word_regex patterns for Rust, a quite popular programming language. It also includes test cases for the xfuncname regex (t4018) and updated documentation. The word_regex pattern finds identifiers, integers, floats and operators, according to the Ru