Re: [PATCH v3] perl: regenerate perl.mak if perl -V changes

2017-03-29 Thread Jeffrey Walton
>>> Now the logic added in commit ee9be06770 ("perl: detect new files in >>> MakeMaker builds", 2012-07-27) is extended to regenerate >>> perl/perl.mak if there's any change to "perl -V". >> >> Nice. This fix is way simpler than I feared. >> >>> This will in some cases redundantly trigger perl/perl

Re: [PATCH v3] perl: regenerate perl.mak if perl -V changes

2017-03-29 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > We'll also redundantly trigger if you upgrade to a minor new perl > version, but I think that's squarely in "who cares" territory. > ... > But I think overall leaning on the side of busting the cache more > often to avoid cryptic errors is the right choice, and w

Re: [PATCH v3] perl: regenerate perl.mak if perl -V changes

2017-03-29 Thread Ævar Arnfjörð Bjarmason
On Wed, Mar 29, 2017 at 8:12 PM, Jeff King wrote: > On Wed, Mar 29, 2017 at 01:57:03PM +, Ævar Arnfjörð Bjarmason wrote: > >> Change the perl/perl.mak build process so that the file is regenerated >> if the output of "perl -V" changes. >> >> Before this change updating e.g. /usr/bin/perl to a

Re: [PATCH v3] perl: regenerate perl.mak if perl -V changes

2017-03-29 Thread Jeff King
On Wed, Mar 29, 2017 at 01:57:03PM +, Ævar Arnfjörð Bjarmason wrote: > Change the perl/perl.mak build process so that the file is regenerated > if the output of "perl -V" changes. > > Before this change updating e.g. /usr/bin/perl to a new major version > would cause the next "make" command t

[PATCH v3] perl: regenerate perl.mak if perl -V changes

2017-03-29 Thread Ævar Arnfjörð Bjarmason
Change the perl/perl.mak build process so that the file is regenerated if the output of "perl -V" changes. Before this change updating e.g. /usr/bin/perl to a new major version would cause the next "make" command to fail, since perl.mak has hardcoded paths to perl library paths retrieved from its