Re: [PATCH v3] pager: move pager-specific setup into the build

2016-08-04 Thread Jeff King
On Thu, Aug 04, 2016 at 11:34:10AM +, Eric Wong wrote: > > > --- a/config.mak.uname > > > +++ b/config.mak.uname > > > @@ -209,6 +209,7 @@ ifeq ($(uname_S),FreeBSD) > > > HAVE_PATHS_H = YesPlease > > > GMTIME_UNRELIABLE_ERRORS = UnfortunatelyYes > > > HAVE_BSD_SYSCTL = YesPlease > > > +

Re: [PATCH v3] pager: move pager-specific setup into the build

2016-08-04 Thread Eric Wong
Jeff King wrote: > On Thu, Aug 04, 2016 at 03:43:01AM +, Eric Wong wrote: > > > +PAGER_ENV_CQ = "$(subst ",\",$(subst \,\\,$(PAGER_ENV)))" > > +PAGER_ENV_CQ_SQ = $(subst ','\'',$(PAGER_ENV_CQ)) > > +BASIC_CFLAGS += -DPAGER_ENV='$(PAGER_ENV_CQ_SQ)' > > Here we set up CQ_SQ, but there is no PA

Re: [PATCH v3] pager: move pager-specific setup into the build

2016-08-03 Thread Jeff King
On Thu, Aug 04, 2016 at 03:43:01AM +, Eric Wong wrote: > +PAGER_ENV_CQ = "$(subst ",\",$(subst \,\\,$(PAGER_ENV)))" > +PAGER_ENV_CQ_SQ = $(subst ','\'',$(PAGER_ENV_CQ)) > +BASIC_CFLAGS += -DPAGER_ENV='$(PAGER_ENV_CQ_SQ)' Here we set up CQ_SQ, but there is no PAGER_ENV_SQ. And then... > @@ -

[PATCH v3] pager: move pager-specific setup into the build

2016-08-03 Thread Eric Wong
From: Junio C Hamano Allowing PAGER_ENV to be set at build-time allows us to move pager-specific knowledge out of our build. This allows us to set a better default for FreeBSD more(1), which misbehaves if MORE environment variable is left empty, but accepts the same variables as less(1) Origina