Re: [PATCH v3] log: forbid log --graph --no-walk

2015-03-16 Thread Manos Pitsidianakis
On 03/16/2015 09:08 PM, Junio C Hamano wrote: > Perhaps 13b25381 (revision: forbid combining --graph and --no-walk, > 2015-03-11) that is queued on 'pu' would be a good answer to this > question? Didn't notice a patch was queued on 'pu', thanks. -- To unsubscribe from this list: send the line "uns

Re: [PATCH v3] log: forbid log --graph --no-walk

2015-03-16 Thread Junio C Hamano
Manos Pitsidianakis writes: > On 03/15/2015 03:39 AM, Dongcan Jiang wrote: >> Because "revs->no_walk" gets set when it comes to "git show". > > So basically rewriting t4052-stat-output.sh to exclude git show --graph > cases (or similar) is not enough. If rewriting git-show code is what is > neede

Re: [PATCH v3] log: forbid log --graph --no-walk

2015-03-16 Thread Manos Pitsidianakis
On 03/15/2015 03:39 AM, Dongcan Jiang wrote: > Because "revs->no_walk" gets set when it comes to "git show". So basically rewriting t4052-stat-output.sh to exclude git show --graph cases (or similar) is not enough. If rewriting git-show code is what is needed, is that in the scope of a microprojec

Re: [PATCH v3] log: forbid log --graph --no-walk

2015-03-14 Thread Dongcan Jiang
Because "revs->no_walk" gets set when it comes to "git show". You can find more information on [1]. [1] http://article.gmane.org/gmane.comp.version-control.git/264921 2015-03-15 9:24 GMT+08:00 Manos Pitsidianakis : > On 03/15/2015 03:08 AM, Dongcan Jiang wrote: >> it seems that your patch could n

Re: [PATCH v3] log: forbid log --graph --no-walk

2015-03-14 Thread Manos Pitsidianakis
On 03/15/2015 03:08 AM, Dongcan Jiang wrote: > it seems that your patch could not pass t4052-stat-output.sh. > > I think it would be better if you could improve the specification for > this change in Document/rev-list-options.txt Can't grok why this happens. What exactly is happening in t4052-sta

Re: [PATCH v3] log: forbid log --graph --no-walk

2015-03-14 Thread Dongcan Jiang
it seems that your patch could not pass t4052-stat-output.sh. I think it would be better if you could improve the specification for this change in Document/rev-list-options.txt 2015-03-15 8:43 GMT+08:00 Manos Pitsidianakis : > In git-log, --graph shows a graphical representation of a continuous >

[PATCH v3] log: forbid log --graph --no-walk

2015-03-14 Thread Manos Pitsidianakis
In git-log, --graph shows a graphical representation of a continuous commit history, and --no-walk shows discrete specified commits without continuity. Using both doesn't make sense, so we forbid the combined use of these flags. Signed-off-by: Manos Pitsidianakis --- This is a microproject intend