Re: [PATCH v3] http-backend: allow empty CONTENT_LENGTH

2018-09-10 Thread Jonathan Nieder
Max Kirillov wrote: > On Sun, Sep 09, 2018 at 10:17:48PM -0700, Jonathan Nieder wrote: >> From: Max Kirillov >> Subject: http-backend test: make empty CONTENT_LENGTH test more realistic > > Thank you, yes, this is what should have left Oh, tying up this loose end: do you know why the test passes

Re: [PATCH v3] http-backend: allow empty CONTENT_LENGTH

2018-09-10 Thread Max Kirillov
On Sun, Sep 09, 2018 at 10:17:48PM -0700, Jonathan Nieder wrote: > From: Max Kirillov > Subject: http-backend test: make empty CONTENT_LENGTH test more realistic Thank you, yes, this is what should have left

Re: [PATCH v3] http-backend: allow empty CONTENT_LENGTH

2018-09-09 Thread Jonathan Nieder
From: Max Kirillov Subject: http-backend test: make empty CONTENT_LENGTH test more realistic This is a test of smart HTTP, so it should use the smart HTTP endpoints (e.g. /info/refs?service=git-receive-pack), not dumb HTTP (HEAD). Signed-off-by: Max Kirillov Signed-off-by: Jonathan Nieder ---

[PATCH v3] http-backend: allow empty CONTENT_LENGTH

2018-09-07 Thread Max Kirillov
Before 817f7dc223, CONTENT_LENGTH variable was never considered, http-backend was just reading request body from standard input until EOF when it, or a command started by it, needed it. Then it was discovered that some HTTP do not close standard input, instead expecting CGI scripts to obey CONTENT