Re: [PATCH v3] commit-graph: remove a duplicate assignment

2019-09-30 Thread Alex Henrie
On Sun, Sep 29, 2019 at 7:22 PM Junio C Hamano wrote: > > Alex Henrie writes: > > > The variable g was being set to the same value both at the beginning of > > the function and before the loop. The assignment before the loop was > > kept because it helps clarify what the loop does, and the redund

Re: [PATCH v3] commit-graph: remove a duplicate assignment

2019-09-29 Thread Junio C Hamano
Alex Henrie writes: > The variable g was being set to the same value both at the beginning of > the function and before the loop. The assignment before the loop was > kept because it helps clarify what the loop does, and the redundant > assignment at the beginning of the function was removed. Wr

[PATCH v3] commit-graph: remove a duplicate assignment

2019-09-28 Thread Alex Henrie
The variable g was being set to the same value both at the beginning of the function and before the loop. The assignment before the loop was kept because it helps clarify what the loop does, and the redundant assignment at the beginning of the function was removed. Reviewed-by: Derrick Stolee Sig