On Sat, Jan 05, 2019 at 08:57:32AM -0800, Erin Dahlgren wrote:
> > So what next? Erin, are you interested in using the details of this
> > conversation to take the cleanups a bit further?
>
> Sure, no problem. If this is urgent, then I would probably be more
> inclined to keep this small and do m
On Fri, Jan 4, 2019 at 12:26 AM Jeff King wrote:
>
> On Thu, Jan 03, 2019 at 10:09:18AM -0800, Junio C Hamano wrote:
>
> > >> @@ -1132,7 +1142,10 @@ const char *setup_git_directory_gently(int
> > >> *nongit_ok)
> > >> * the user has set GIT_DIR. It may be beneficial to disallow bogus
> > >>
On Thu, Jan 03, 2019 at 10:09:18AM -0800, Junio C Hamano wrote:
> >> @@ -1132,7 +1142,10 @@ const char *setup_git_directory_gently(int
> >> *nongit_ok)
> >> * the user has set GIT_DIR. It may be beneficial to disallow bogus
> >> * GIT_DIR values at some point in the future.
> >> */
>
>Subject: Re: [PATCH v3] Simplify handling of setup_git_directory_gently()
>failure cases.
Perhaps
Subject: setup: simplify setup_git_directory_gently() failure cases
to clarify which part of the entire world this patch is touching.
Jeff King writes:
> This patch isn&#x
On Thu, Dec 27, 2018 at 03:36:29PM -0800, Erin Dahlgren wrote:
> Before this change are two misleading additional behaviors:
>
> - GIT_DIR_HIT_CEILING: setup_nongit() changes to the cwd for no
> apparent reason. We never had the chance to change directories
> up to this point so chd
setup_git_directory_gently() expects two types of failures to
discover a git directory (e.g. .git/):
- GIT_DIR_HIT_CEILING: could not find a git directory in any
parent directories of the cwd.
- GIT_DIR_HIT_MOUNT_POINT: could not find a git directory in
any parent directories u
6 matches
Mail list logo
