Junio and Eric,
Thank you for the reviews and helpful advice.
I should have read more past commit messages before send patch.
Regards,
2014-03-21 3:20 GMT+09:00 Junio C Hamano :
> Hiroyuki Sano writes:
>
>> fsck_tree() has two different ways to set a flag,
>> which are the followings:
>>
>>
Junio C Hamano writes:
> In other words, "it is brief and to the point" merely _allows_ these
> statements to be expressed in the latter form; it does not say
> anything about which is better between the former and the latter.
In any case, that is a minor point. I'll queue the patch on 'pu',
wi
Hiroyuki Sano writes:
> fsck_tree() has two different ways to set a flag,
> which are the followings:
>
> 1. Using a if-statement that guards assignment.
>
> 2. Using a bitwise-or assignment operator.
>
> Currently, many with the former way,
> and one with the latter way.
>
> In this patch, u
fsck_tree() has two different ways to set a flag,
which are the followings:
1. Using a if-statement that guards assignment.
2. Using a bitwise-or assignment operator.
Currently, many with the former way,
and one with the latter way.
In this patch, unify them to the latter way,
because it ma
4 matches
Mail list logo
