Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

2017-11-10 Thread Оля Тележная
> We hung back on it to leave it as low-hanging fruit for other Outreachy > applicants. Perhaps Olga would like to pick it up now that the > application period is over. It's absolutely not a problem for me, I can do that as one more warm-up exercise in the beginning of the internship. Thanks!

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

2017-11-07 Thread Jeff King
On Wed, Nov 08, 2017 at 10:44:46AM +0900, Junio C Hamano wrote: > > We could also consider it a #leftoverbits that perhaps some other > > Outreachy candidate would pick up[1]. > > > > In the meantime, Junio, I think we'd want to queue this with the intent > > to graduate it to "pu" or possibly "ne

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

2017-11-07 Thread Junio C Hamano
Jeff King writes: > I do think there are a few ugly bits in the result (like that > initializer for packed_git_mru :) ), so I'd prefer not to merge this > down until we do that final step. > > So the big question is: who wants to do it? > > I think you've done a good job here, and this would coun

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

2017-10-03 Thread Jeff King
On Mon, Oct 02, 2017 at 12:37:53PM +0300, Оля Тележная wrote: > >> Simplify mru.[ch] and related code by reusing the double-linked list > >> implementation from list.h instead of a custom one. > >> This commit is an intermediate step. Our final goal is to get rid of > >> mru.[ch] at all and inline

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

2017-10-02 Thread Оля Тележная
>> Simplify mru.[ch] and related code by reusing the double-linked list >> implementation from list.h instead of a custom one. >> This commit is an intermediate step. Our final goal is to get rid of >> mru.[ch] at all and inline all logic. > > Thanks, this version looks correct to me. Great! What

Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

2017-10-02 Thread Jeff King
On Sat, Sep 30, 2017 at 05:51:01PM +, Olga Telezhnaya wrote: > Simplify mru.[ch] and related code by reusing the double-linked list > implementation from list.h instead of a custom one. > This commit is an intermediate step. Our final goal is to get rid of > mru.[ch] at all and inline all logi

[PATCH v2 Outreachy] mru: use double-linked list from list.h

2017-09-30 Thread Olga Telezhnaya
Simplify mru.[ch] and related code by reusing the double-linked list implementation from list.h instead of a custom one. This commit is an intermediate step. Our final goal is to get rid of mru.[ch] at all and inline all logic. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder Mentore