Re: [PATCH v2 7/9] gpg-interface: introduce new config to select per gpg format program

2018-07-16 Thread Junio C Hamano
Jeff King writes: > On Mon, Jul 16, 2018 at 02:56:34PM -0700, Junio C Hamano wrote: > >> >> I'm okay with us forcing "openpgp". That seems sane enough for now, and >> >> if people scream loudly, we can loosen it. >> > >> > Well, I specifically meant "are you sure subsections like this are a >> >

Re: [PATCH v2 7/9] gpg-interface: introduce new config to select per gpg format program

2018-07-16 Thread Jeff King
On Mon, Jul 16, 2018 at 02:56:34PM -0700, Junio C Hamano wrote: > >> I'm okay with us forcing "openpgp". That seems sane enough for now, and > >> if people scream loudly, we can loosen it. > > > > Well, I specifically meant "are you sure subsections like this are a > > good idea". But it seems li

Re: [PATCH v2 7/9] gpg-interface: introduce new config to select per gpg format program

2018-07-16 Thread Junio C Hamano
Jeff King writes: > On Sat, Jul 14, 2018 at 06:13:47PM +, brian m. carlson wrote: > >> On Tue, Jul 10, 2018 at 12:56:38PM -0400, Jeff King wrote: >> > On Tue, Jul 10, 2018 at 12:54:13PM -0400, Jeff King wrote: >> > >> > > Should we allow: >> > > >> > > [gpg "OpenPGP"] >> > > program = w

Re: [PATCH v2 7/9] gpg-interface: introduce new config to select per gpg format program

2018-07-16 Thread Jeff King
On Sat, Jul 14, 2018 at 06:13:47PM +, brian m. carlson wrote: > On Tue, Jul 10, 2018 at 12:56:38PM -0400, Jeff King wrote: > > On Tue, Jul 10, 2018 at 12:54:13PM -0400, Jeff King wrote: > > > > > Should we allow: > > > > > > [gpg "OpenPGP"] > > > program = whatever > > > > > > given tha

Re: [PATCH v2 7/9] gpg-interface: introduce new config to select per gpg format program

2018-07-14 Thread brian m. carlson
On Tue, Jul 10, 2018 at 12:56:38PM -0400, Jeff King wrote: > On Tue, Jul 10, 2018 at 12:54:13PM -0400, Jeff King wrote: > > > Should we allow: > > > > [gpg "OpenPGP"] > > program = whatever > > > > given that we allow: > > > > [gpg] > > format = OpenPGP > > > > ? I think just using str

Re: [PATCH v2 7/9] gpg-interface: introduce new config to select per gpg format program

2018-07-13 Thread Henning Schild
Replies to this one have been ignored for v3. I do not know how to proceed here. Henning Am Tue, 10 Jul 2018 10:52:29 +0200 schrieb Henning Schild : > Supporting multiple signing formats we will have the need to > configure a custom program each. Add a new config value to cater for > that. > >

Re: [PATCH v2 7/9] gpg-interface: introduce new config to select per gpg format program

2018-07-10 Thread Junio C Hamano
Jeff King writes: > Should we allow: > > [gpg "OpenPGP"] > program = whatever > > given that we allow: > > [gpg] > format = OpenPGP If the latter is allowed then we should allow the former. But because allowing the former is cumbersome, we may be better off not parsing the value case-

Re: [PATCH v2 7/9] gpg-interface: introduce new config to select per gpg format program

2018-07-10 Thread Jeff King
On Tue, Jul 10, 2018 at 12:54:13PM -0400, Jeff King wrote: > Should we allow: > > [gpg "OpenPGP"] > program = whatever > > given that we allow: > > [gpg] > format = OpenPGP > > ? I think just using strcasecmp() here would be sufficient. But I wonder > if it is a symptom of using the wr

Re: [PATCH v2 7/9] gpg-interface: introduce new config to select per gpg format program

2018-07-10 Thread Jeff King
On Tue, Jul 10, 2018 at 10:52:29AM +0200, Henning Schild wrote: > diff --git a/Documentation/config.txt b/Documentation/config.txt > index ac373e3f4..c0bd80954 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -1832,6 +1832,11 @@ gpg.format:: > Specifies which key

[PATCH v2 7/9] gpg-interface: introduce new config to select per gpg format program

2018-07-10 Thread Henning Schild
Supporting multiple signing formats we will have the need to configure a custom program each. Add a new config value to cater for that. Signed-off-by: Henning Schild --- Documentation/config.txt | 5 + gpg-interface.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --g