Re: [PATCH v2 7/7] wt-status.c: avoid double renames in short/porcelain format

2017-12-27 Thread Igor Djordjevic
On 27/12/2017 01:49, Duy Nguyen wrote: > > > I lost you a bit here, partially because of what seems to be an > > incomplete setup script, partially because of this last sentence, as > > Git v2.15.1 doesn`t seem to be showing this, so not sure about "like > > we have been showing until now" part...

Re: [PATCH v2 7/7] wt-status.c: avoid double renames in short/porcelain format

2017-12-26 Thread Duy Nguyen
On Wed, Dec 27, 2017 at 5:14 AM, Igor Djordjevic wrote: > Hi Duy, > > On 26/12/2017 10:10, Nguyễn Thái Ngọc Duy wrote: >> >> The presence of worktree rename leads to an interesting situation, >> what if the same index entry is renamed twice, compared to HEAD and to >> worktree? We can have that wi

Re: [PATCH v2 7/7] wt-status.c: avoid double renames in short/porcelain format

2017-12-26 Thread Igor Djordjevic
Hi Duy, On 26/12/2017 10:10, Nguyễn Thái Ngọc Duy wrote: > > The presence of worktree rename leads to an interesting situation, > what if the same index entry is renamed twice, compared to HEAD and to > worktree? We can have that with this setup > > echo first > first && git add first && git

[PATCH v2 7/7] wt-status.c: avoid double renames in short/porcelain format

2017-12-26 Thread Nguyễn Thái Ngọc Duy
The presence of worktree rename leads to an interesting situation, what if the same index entry is renamed twice, compared to HEAD and to worktree? We can have that with this setup echo first > first && git add first && git commit -m first git mv first second # rename reported in "diff --