Re: [PATCH v2 6/9] streaming_write_entry: propagate streaming errors

2013-03-26 Thread Junio C Hamano
Jeff King writes: > Subject: [PATCH] streaming_write_entry: propagate streaming errors > > When we are streaming an index blob to disk, we store the > error from stream_blob_to_fd in the "result" variable, and > then immediately overwrite that with the return value of > "close". That means we cat

Re: [PATCH v2 6/9] streaming_write_entry: propagate streaming errors

2013-03-25 Thread Jonathan Nieder
Jeff King wrote: > Both fixed in my re-roll. Thanks! This and the rest of the patches up to and including patch 8 look good to me. I haven't decided what to think about patch 9 yet, but I suspect it would be good, too. In the long term I suspect "git clone --worktree-only " (or some other stan

[PATCH v2 6/9] streaming_write_entry: propagate streaming errors

2013-03-25 Thread Jeff King
On Mon, Mar 25, 2013 at 02:39:34PM -0700, Jonathan Nieder wrote: > > --- a/entry.c > > +++ b/entry.c > > @@ -126,8 +126,10 @@ static int streaming_write_entry(struct cache_entry > > *ce, char *path, > > fd = open_output_fd(path, ce, to_tempfile); > > if (0 <= fd) { > > result