Re: [PATCH v2 6/7] rebase: write better reflog messages

Junio C Hamano writes: > Junio C Hamano writes: > >> Excellent question, and I think this illustrates why the recent >> reroll that uses an approach to use base_reflog_action is not >> complete and needs further work (to put it mildly). >> ... >> That essentially boils down to the very original

Re: [PATCH v2 6/7] rebase: write better reflog messages

Junio C Hamano writes: > Excellent question, and I think this illustrates why the recent > reroll that uses an approach to use base_reflog_action is not > complete and needs further work (to put it mildly). > ... > That essentially boils down to the very original suggestion I made > before Ram in

Re: [PATCH v2 6/7] rebase: write better reflog messages

Johannes Sixt writes: > Am 6/18/2013 20:55, schrieb Ramkumar Ramachandra: >> Now that the "checkout" invoked internally from "rebase" knows to honor >> GIT_REFLOG_ACTION, we can start to use it to write a better reflog >> message when "rebase anotherbranch", "rebase --onto branch", >> etc. intern

Re: [PATCH v2 6/7] rebase: write better reflog messages

Am 6/19/2013 8:09, schrieb Ramkumar Ramachandra: > Johannes Sixt wrote: >> I haven't followed the topic closely, but I wonder why there are so many >> explicit assignments to GIT_REFLOG_ACTION. Is calling set_reflog_action >> (defined in git-sh-setup) the wrong thing to do? > > Does this answer yo

Re: [PATCH v2 6/7] rebase: write better reflog messages

Johannes Sixt wrote: > I haven't followed the topic closely, but I wonder why there are so many > explicit assignments to GIT_REFLOG_ACTION. Is calling set_reflog_action > (defined in git-sh-setup) the wrong thing to do? Does this answer your question? set_reflog_action() { if [ -z "${GIT

Re: [PATCH v2 6/7] rebase: write better reflog messages

Am 6/18/2013 20:55, schrieb Ramkumar Ramachandra: > Now that the "checkout" invoked internally from "rebase" knows to honor > GIT_REFLOG_ACTION, we can start to use it to write a better reflog > message when "rebase anotherbranch", "rebase --onto branch", > etc. internally checks out the new fork p

Re: [PATCH v2 6/7] rebase: write better reflog messages

Ramkumar Ramachandra writes: > Now that the "checkout" invoked internally from "rebase" knows to honor > GIT_REFLOG_ACTION, we can start to use it to write a better reflog > message when "rebase anotherbranch", "rebase --onto branch", > etc. internally checks out the new fork point. We will writ

[PATCH v2 6/7] rebase: write better reflog messages

Now that the "checkout" invoked internally from "rebase" knows to honor GIT_REFLOG_ACTION, we can start to use it to write a better reflog message when "rebase anotherbranch", "rebase --onto branch", etc. internally checks out the new fork point. We will write: rebase: checkout master instead