Re: [PATCH v2 6/7] correct blame for files commited with CRLF

2016-04-03 Thread Torsten Bögershausen
Thanks for all the comments. I just reallized that t6038 is broken, which I didn't notice before :-( Please feel free to kick out tb/safe-crlf-output-fix from pu, until I have looked into the breakage and found a fix. -- To unsubscribe from this list: send the line "unsubscribe git" in the body

Re: [PATCH v2 6/7] correct blame for files commited with CRLF

2016-04-01 Thread Junio C Hamano
tbo...@web.de writes: > Whenever a CLRF conversion is needed (or any filter us set), load the > index temporally, before calling convert_to_git() I am not sure if this is needed. We should just do read_cache() unconditionally at the beginning of fake_working_tree_commit(), without even discardin

[PATCH v2 6/7] correct blame for files commited with CRLF

2016-04-01 Thread tboegi
From: Torsten Bögershausen git blame reports lines as not "Not Committed Yet" when they have CRLF in the index, CRLF in the worktree and e.g. core.autocrlf is true. Since commit c48053 "new safer autocrlf handling", files that have CRLF in the index are not normalized at commit when e.g. core.au