Re: [PATCH v2 6/6] commit-graph: add repo arg to graph readers

> >> Also, this will conflict with sb/object-store-lookup, won't it? I'm > >> guessing this is why you didn't touch the "git commit-graph > >> [write|verify]"code paths. > > It will conflict because of the change to lookup_commit(), but the only > > new code I'm writing is in t/helper/test-reposito

Re: [PATCH v2 6/6] commit-graph: add repo arg to graph readers

On 7/10/2018 1:31 PM, Jonathan Tan wrote: +static void test_get_commit_tree_in_graph(const char *gitdir, + const char *worktree, + const struct object_id *commit_oid) +{ + struct repository r; + struct c

Re: [PATCH v2 6/6] commit-graph: add repo arg to graph readers

> > - if (!core_commit_graph) > > + if (repo_config_get_bool(r, "core.commitgraph", &config_value) || > > + !config_value) > > + /* > > +* This repository is not configured to use commit graphs, so > > +* do not load one. (But report commit_graph_attempte

Re: [PATCH v2 6/6] commit-graph: add repo arg to graph readers

On Tue, Jul 10, 2018 at 6:18 AM, Johannes Schindelin wrote: >> 32-bit builds complain about this: >> >> t/helper/test-repository.c: In function 'test_parse_commit_in_graph': >> t/helper/test-repository.c:28:9: error: format '%lu' expects argument of >> type 'long unsigned int', but argument 2

Re: [PATCH v2 6/6] commit-graph: add repo arg to graph readers

Hi, On Tue, 10 Jul 2018, SZEDER Gábor wrote: > > diff --git a/t/helper/test-repository.c b/t/helper/test-repository.c > > new file mode 100644 > > index 00..5fff540a26 > > --- /dev/null > > +++ b/t/helper/test-repository.c > > @@ -0,0 +1,88 @@ > > +#include "test-tool.h" > > +#include "ca

Re: [PATCH v2 6/6] commit-graph: add repo arg to graph readers

> diff --git a/t/helper/test-repository.c b/t/helper/test-repository.c > new file mode 100644 > index 00..5fff540a26 > --- /dev/null > +++ b/t/helper/test-repository.c > @@ -0,0 +1,88 @@ > +#include "test-tool.h" > +#include "cache.h" > +#include "commit-graph.h" > +#include "commit.h" > +#

Re: [PATCH v2 6/6] commit-graph: add repo arg to graph readers

On 7/9/2018 4:44 PM, Jonathan Tan wrote: Add a struct repository argument to the functions in commit-graph.h that read the commit graph. (This commit does not affect functions that write commit graphs.) Because the commit graph functions can now read the commit graph of any repository, the globa

[PATCH v2 6/6] commit-graph: add repo arg to graph readers

Add a struct repository argument to the functions in commit-graph.h that read the commit graph. (This commit does not affect functions that write commit graphs.) Because the commit graph functions can now read the commit graph of any repository, the global variable core_commit_graph has been remov