Re: [PATCH v2 5/8] t1308: relax the test verifying that empty alias values are disallowed

2017-06-13 Thread Junio C Hamano
Johannes Schindelin writes: > Sadly, I do not think so. It is just different, not better. Maybe less > redundant... See for yourself: Yup, I noticed and was referring to this "less redundant" as an improvement, actually. > The real fix would indeed be (as mentioned by Brandon elsewhere) to unif

Re: [PATCH v2 5/8] t1308: relax the test verifying that empty alias values are disallowed

2017-06-13 Thread Johannes Schindelin
Hi Junio, On Sat, 10 Jun 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > We are about to change the way aliases are expanded, to use the early > > config machinery. > > > > This machinery reports errors in a slightly different manner than the > > cached config machinery. > > > >

Re: [PATCH v2 5/8] t1308: relax the test verifying that empty alias values are disallowed

2017-06-09 Thread Junio C Hamano
Johannes Schindelin writes: > We are about to change the way aliases are expanded, to use the early > config machinery. > > This machinery reports errors in a slightly different manner than the > cached config machinery. > > Let's not get hung up by the precise wording of the message mentioning >

[PATCH v2 5/8] t1308: relax the test verifying that empty alias values are disallowed

2017-06-08 Thread Johannes Schindelin
We are about to change the way aliases are expanded, to use the early config machinery. This machinery reports errors in a slightly different manner than the cached config machinery. Let's not get hung up by the precise wording of the message mentioning the lin number. It is really sufficient to