Re: [PATCH v2 5/6] submodule: improve submodule_has_commits

2017-05-02 Thread Brandon Williams
On 05/02, Brandon Williams wrote: > On 05/02, Stefan Beller wrote: > > On Tue, May 2, 2017 at 10:25 AM, Brandon Williams wrote: > > > On 05/01, Stefan Beller wrote: > > >> On Mon, May 1, 2017 at 6:02 PM, Brandon Williams > > >> wrote: > > >> > + > > >> > + if (capture_command(&cp,

Re: [PATCH v2 5/6] submodule: improve submodule_has_commits

2017-05-02 Thread Brandon Williams
On 05/02, Stefan Beller wrote: > On Tue, May 2, 2017 at 10:25 AM, Brandon Williams wrote: > > On 05/01, Stefan Beller wrote: > >> On Mon, May 1, 2017 at 6:02 PM, Brandon Williams wrote: > >> > + > >> > + if (capture_command(&cp, &out, GIT_MAX_HEXSZ + 1) || > >> > out.len) > >> > >>

Re: [PATCH v2 5/6] submodule: improve submodule_has_commits

2017-05-02 Thread Stefan Beller
On Tue, May 2, 2017 at 10:25 AM, Brandon Williams wrote: > On 05/01, Stefan Beller wrote: >> On Mon, May 1, 2017 at 6:02 PM, Brandon Williams wrote: >> > + >> > + if (capture_command(&cp, &out, GIT_MAX_HEXSZ + 1) || >> > out.len) >> >> eh, I gave too much and self-contradicting fee

Re: [PATCH v2 5/6] submodule: improve submodule_has_commits

2017-05-02 Thread Brandon Williams
On 05/01, Stefan Beller wrote: > On Mon, May 1, 2017 at 6:02 PM, Brandon Williams wrote: > > + > > + if (capture_command(&cp, &out, GIT_MAX_HEXSZ + 1) || > > out.len) > > eh, I gave too much and self-contradicting feedback here earlier, > ideally I'd like to review this to be simil

Re: [PATCH v2 5/6] submodule: improve submodule_has_commits

2017-05-01 Thread Stefan Beller
On Mon, May 1, 2017 at 6:02 PM, Brandon Williams wrote: > Teach 'submodule_has_commits()' to ensure that if a commit exists in a > submodule, that it is also reachable from a ref. > > This is a preparatory step prior to merging the logic which checks for > changed submodules when fetching or pushi

[PATCH v2 5/6] submodule: improve submodule_has_commits

2017-05-01 Thread Brandon Williams
Teach 'submodule_has_commits()' to ensure that if a commit exists in a submodule, that it is also reachable from a ref. This is a preparatory step prior to merging the logic which checks for changed submodules when fetching or pushing. Change-Id: I4fed2acfa7e69a5fbbca534df165671e77a90f22 Signed-o