Re: [PATCH v2 5/6] git-reflog: add create and exists functions

2015-06-25 Thread David Turner
On Thu, 2015-06-25 at 16:45 -0400, David Turner wrote: > +static int cmd_reflog_create(int argc, const char **argv, const char *prefix) > +{ While revising this patch, I noticed that safe_create_reflog (and this cmd_reflog_create) only creates reflogs for refs of the form that git itself would aut

Re: [PATCH v2 5/6] git-reflog: add create and exists functions

2015-06-25 Thread Junio C Hamano
David Turner writes: Because...??? > These are necessary because ref backends manage reflogs. "Because ref backends manage reflogs" may be a good explanation to implement something as part of ref API, but it does not explain why that something needs to be implemented in the first place. > In a

[PATCH v2 5/6] git-reflog: add create and exists functions

2015-06-25 Thread David Turner
These are necessary because ref backends manage reflogs. In a moment, we will use these functions to make git stash work with alternate ref backends. Signed-off-by: David Turner --- builtin/reflog.c | 79 +++- 1 file changed, 78 insertions(+),