Re: [PATCH v2 4/6] config: don't implicitly use gitdir

2017-06-14 Thread Brandon Williams
On 06/14, Jeff King wrote: > On Tue, Jun 13, 2017 at 02:38:15PM -0700, Brandon Williams wrote: > > > > The same comments as before still apply: > > > > > > - this changes API to make opts->git_dir mandatory, which is error prone > > > and easily avoidable, e.g. by making git_dir an argument to

Re: [PATCH v2 4/6] config: don't implicitly use gitdir

2017-06-13 Thread Jeff King
On Tue, Jun 13, 2017 at 02:38:15PM -0700, Brandon Williams wrote: > > The same comments as before still apply: > > > > - this changes API to make opts->git_dir mandatory, which is error prone > > and easily avoidable, e.g. by making git_dir an argument to > > git_config_with_options > > I st

Re: [PATCH v2 4/6] config: don't implicitly use gitdir

2017-06-13 Thread Jacob Keller
On Tue, Jun 13, 2017 at 3:05 PM, Jonathan Nieder wrote: > Junio C Hamano wrote: >> On Tue, Jun 13, 2017 at 2:51 PM, Jonathan Nieder wrote: > >>> What is the next step, then? You can find the notion ridiculous but >>> it's how this project has worked in my experience (and how other >>> projects w

Re: [PATCH v2 4/6] config: don't implicitly use gitdir

2017-06-13 Thread Jonathan Nieder
Junio C Hamano wrote: > On Tue, Jun 13, 2017 at 2:51 PM, Jonathan Nieder wrote: >> What is the next step, then? You can find the notion ridiculous but >> it's how this project has worked in my experience (and how other >> projects with similar patch-based workflows work). > > Does "patch-based"

Re: [PATCH v2 4/6] config: don't implicitly use gitdir

2017-06-13 Thread Junio C Hamano
On Tue, Jun 13, 2017 at 2:51 PM, Jonathan Nieder wrote: > > What is the next step, then? You can find the notion ridiculous but > it's how this project has worked in my experience (and how other > projects with similar patch-based workflows work). Does "patch-based" have much to do with this? I

Re: [PATCH v2 4/6] config: don't implicitly use gitdir

2017-06-13 Thread Jonathan Nieder
Brandon Williams wrote: > On 06/13, Jonathan Nieder wrote: >> Brandon Williams wrote: >>> Commit 2185fde56 (config: handle conditional include when $GIT_DIR is >>> not set up) added a 'git_dir' field to the config_options struct. Let's >>> use this option field explicitly all the time instead of

Re: [PATCH v2 4/6] config: don't implicitly use gitdir

2017-06-13 Thread Brandon Williams
On 06/13, Jonathan Nieder wrote: > Brandon Williams wrote: > > > Commit 2185fde56 (config: handle conditional include when $GIT_DIR is > > not set up) added a 'git_dir' field to the config_options struct. Let's > > use this option field explicitly all the time instead of occasionally > > falling

Re: [PATCH v2 4/6] config: don't implicitly use gitdir

2017-06-13 Thread Jonathan Nieder
Brandon Williams wrote: > Commit 2185fde56 (config: handle conditional include when $GIT_DIR is > not set up) added a 'git_dir' field to the config_options struct. Let's > use this option field explicitly all the time instead of occasionally > falling back to calling 'git_pathdup("config")' to ge

[PATCH v2 4/6] config: don't implicitly use gitdir

2017-06-13 Thread Brandon Williams
Commit 2185fde56 (config: handle conditional include when $GIT_DIR is not set up) added a 'git_dir' field to the config_options struct. Let's use this option field explicitly all the time instead of occasionally falling back to calling 'git_pathdup("config")' to get the path to the local repositor