Re: [PATCH v2 4/4] log: --author-date-order

2013-06-20 Thread Jeff King
On Thu, Jun 20, 2013 at 12:36:21PM -0700, Junio C Hamano wrote: > > I like the latter option. It takes a non-trivial amount of time to load > > the commits from disk, and now we are potentially doing it 2 or 3 times > > for a run (once to parse, once to get the author info for topo-sort, and > > p

Re: [PATCH v2 4/4] log: --author-date-order

2013-06-20 Thread Junio C Hamano
Jeff King writes: >> Or we could extend parse_commit() API to take an optional commit >> info slab to store not just author date but other non-essential >> stuff like people's names, and we arrange that extended API to be >> triggered when we know --author-date-order is in effect? > > I like the

Re: [PATCH v2 4/4] log: --author-date-order

2013-06-10 Thread Jeff King
On Mon, Jun 10, 2013 at 12:39:24AM -0700, Junio C Hamano wrote: > > I'm not excited about introducing yet another place that parses commit > > objects (mostly not for correctness, but because we have had > > inconsistency in how malformed objects are treated). It is at least > > using split_ident_

Re: [PATCH v2 4/4] log: --author-date-order

2013-06-10 Thread Junio C Hamano
Jeff King writes: > I'm not excited about introducing yet another place that parses commit > objects (mostly not for correctness, but because we have had > inconsistency in how malformed objects are treated). It is at least > using split_ident_line which covers the hard bits. I wonder how much >

Re: [PATCH v2 4/4] log: --author-date-order

2013-06-09 Thread Jeff King
On Sun, Jun 09, 2013 at 04:24:37PM -0700, Junio C Hamano wrote: > Sometimes people would want to view the commits in parallel > histories in the order of author dates, not committer dates. > > Teach "topo-order" sort machinery to do so, using a commit-info slab > to record the author dates of eac

[PATCH v2 4/4] log: --author-date-order

2013-06-09 Thread Junio C Hamano
Sometimes people would want to view the commits in parallel histories in the order of author dates, not committer dates. Teach "topo-order" sort machinery to do so, using a commit-info slab to record the author dates of each commit, and commit-queue to sort them. Signed-off-by: Junio C Hamano --