Re: [PATCH v2 4/4] git-p4: Disable t9819 git-p4-case-folding test on OS X

2015-10-04 Thread Junio C Hamano
Lars Schneider writes: > By the way... what formatting should I use? > > if foo > then > bar > > or > > if foo; then > bar > > I think the latter is more used in the code base. I've allowed the latter in fringe scripts (i.e. the ones that I do not care too deeply) over time, but Documentatio

Re: [PATCH v2 4/4] git-p4: Disable t9819 git-p4-case-folding test on OS X

2015-10-04 Thread Lars Schneider
On 04 Oct 2015, at 11:26, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider >> >> The OS X file system is case insensitive by default. Consequently this >> test does not apply. >> >> Signed-off-by: Lars Schneider >> --- >> t/t9819-git-p4-case-folding.sh | 5

Re: [PATCH v2 4/4] git-p4: Disable t9819 git-p4-case-folding test on OS X

2015-10-04 Thread Junio C Hamano
larsxschnei...@gmail.com writes: > From: Lars Schneider > > The OS X file system is case insensitive by default. Consequently this > test does not apply. > > Signed-off-by: Lars Schneider > --- > t/t9819-git-p4-case-folding.sh | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/t/t981

[PATCH v2 4/4] git-p4: Disable t9819 git-p4-case-folding test on OS X

2015-10-04 Thread larsxschneider
From: Lars Schneider The OS X file system is case insensitive by default. Consequently this test does not apply. Signed-off-by: Lars Schneider --- t/t9819-git-p4-case-folding.sh | 5 + 1 file changed, 5 insertions(+) diff --git a/t/t9819-git-p4-case-folding.sh b/t/t9819-git-p4-case-foldin