Re: [PATCH v2 3/6] grep.[ch]: teach columnnum, color_columnno to grep_opt

On Sun, Apr 22, 2018 at 08:21:33PM -0400, Eric Sunshine wrote: > On Sun, Apr 22, 2018 at 7:24 PM, Taylor Blau wrote: > > On Sun, Apr 22, 2018 at 11:42:48PM +0200, Ęvar Arnfjörš Bjarmason wrote: > >> On Sun, Apr 22 2018, Taylor Blau wrote: > >> > In preparation of adding --column-number to 'git-gre

Re: [PATCH v2 3/6] grep.[ch]: teach columnnum, color_columnno to grep_opt

On Sun, Apr 22, 2018 at 7:24 PM, Taylor Blau wrote: > On Sun, Apr 22, 2018 at 11:42:48PM +0200, Ęvar Arnfjörš Bjarmason wrote: >> On Sun, Apr 22 2018, Taylor Blau wrote: >> > In preparation of adding --column-number to 'git-grep(1)', we extend >> > grep_opt to take in the requisite new members. >>

Re: [PATCH v2 3/6] grep.[ch]: teach columnnum, color_columnno to grep_opt

On Sun, Apr 22, 2018 at 11:42:48PM +0200, Ævar Arnfjörð Bjarmason wrote: > On Sun, Apr 22 2018, Taylor Blau wrote: > > > In preparation of adding --column-number to 'git-grep(1)', we extend > > grep_opt to take in the requisite new members. > > Just a nit: Makes sense to refer to these camel-cased

Re: [PATCH v2 3/6] grep.[ch]: teach columnnum, color_columnno to grep_opt

On Sun, Apr 22 2018, Taylor Blau wrote: I think [345]/6 would make much more sense as just one patch. Comments on them to follow... > In preparation of adding --column-number to 'git-grep(1)', we extend > grep_opt to take in the requisite new members. Just a nit: Makes sense to refer to these c

[PATCH v2 3/6] grep.[ch]: teach columnnum, color_columnno to grep_opt

In preparation of adding --column-number to 'git-grep(1)', we extend grep_opt to take in the requisite new members. We additionally teach the 'grep.columnnumber' and 'color.grep.columnnumber' configuration variables to configure showing and coloring the column number, respectively. (These options