Re: [PATCH v2 3/6] clean: read user input with strbuf_getline()

2016-02-22 Thread Junio C Hamano
Eric Sunshine writes: > On Sun, Feb 21, 2016 at 8:20 PM, Moritz Neeb wrote: >> The inputs that are read are all answers that are given by the user >> when interacting with git on the commandline. As these answers are >> not supposed to contain a meaningful CR it is safe to >> replace strbuf_getl

Re: [PATCH v2 3/6] clean: read user input with strbuf_getline()

2016-02-21 Thread Moritz Neeb
On 02/22/2016 03:27 AM, Eric Sunshine wrote: > On Sun, Feb 21, 2016 at 8:20 PM, Moritz Neeb wrote: >> The inputs that are read are all answers that are given by the user >> when interacting with git on the commandline. As these answers are >> not supposed to contain a meaningful CR it is safe to >

Re: [PATCH v2 3/6] clean: read user input with strbuf_getline()

2016-02-21 Thread Eric Sunshine
On Sun, Feb 21, 2016 at 8:20 PM, Moritz Neeb wrote: > The inputs that are read are all answers that are given by the user > when interacting with git on the commandline. As these answers are > not supposed to contain a meaningful CR it is safe to > replace strbuf_getline_lf() can be replaced by st

[PATCH v2 3/6] clean: read user input with strbuf_getline()

2016-02-21 Thread Moritz Neeb
The inputs that are read are all answers that are given by the user when interacting with git on the commandline. As these answers are not supposed to contain a meaningful CR it is safe to replace strbuf_getline_lf() can be replaced by strbuf_getline(). Before the user input was trimmed to remove