Re: [PATCH v2 3/4] t4203: test mailmap functionality directly rather than indirectly

2013-07-11 Thread Junio C Hamano
Eric Sunshine writes: > On Fri, Jul 12, 2013 at 1:48 AM, Junio C Hamano wrote: >> Jonathan Nieder writes: >> >>> My current thinking is "no" --- the patch has as a justification "Now >>> we can test these aspects of .mailmap handling directly with a >>> low-level tool instead of using the tool

Re: [PATCH v2 3/4] t4203: test mailmap functionality directly rather than indirectly

2013-07-11 Thread Eric Sunshine
On Fri, Jul 12, 2013 at 1:48 AM, Junio C Hamano wrote: > Jonathan Nieder writes: > >> My current thinking is "no" --- the patch has as a justification "Now >> we can test these aspects of .mailmap handling directly with a >> low-level tool instead of using the tool most people will use, so do >>

Re: [PATCH v2 3/4] t4203: test mailmap functionality directly rather than indirectly

2013-07-11 Thread Junio C Hamano
Jonathan Nieder writes: > My current thinking is "no" --- the patch has as a justification "Now > we can test these aspects of .mailmap handling directly with a > low-level tool instead of using the tool most people will use, so do > so", which sounds an awful lot like "Reduce test coverage of co

Re: [PATCH v2 3/4] t4203: test mailmap functionality directly rather than indirectly

2013-07-11 Thread Eric Sunshine
On Thu, Jul 11, 2013 at 8:55 PM, Jonathan Nieder wrote: > Eric Sunshine wrote: >> On Thu, Jul 11, 2013 at 3:07 PM, Junio C Hamano wrote: >>> Eric Sunshine writes: > With the introduction of check-mailmap, it is now possible to check .mailmap functionality directly rather than indirectl

Re: [PATCH v2 3/4] t4203: test mailmap functionality directly rather than indirectly

2013-07-11 Thread Jonathan Nieder
Eric Sunshine wrote: > On Thu, Jul 11, 2013 at 3:07 PM, Junio C Hamano wrote: >> Eric Sunshine writes: >>> With the introduction of check-mailmap, it is now possible to check >>> .mailmap functionality directly rather than indirectly as a side-effect >>> of other commands (such as git-shortlog),

Re: [PATCH v2 3/4] t4203: test mailmap functionality directly rather than indirectly

2013-07-11 Thread Eric Sunshine
On Thu, Jul 11, 2013 at 3:07 PM, Junio C Hamano wrote: > Eric Sunshine writes: > >> With the introduction of check-mailmap, it is now possible to check >> .mailmap functionality directly rather than indirectly as a side-effect >> of other commands (such as git-shortlog), therefore, do so. > > Doe

Re: [PATCH v2 3/4] t4203: test mailmap functionality directly rather than indirectly

2013-07-11 Thread Junio C Hamano
Eric Sunshine writes: > With the introduction of check-mailmap, it is now possible to check > .mailmap functionality directly rather than indirectly as a side-effect > of other commands (such as git-shortlog), therefore, do so. Does this patch mean that we will now ignore future breakages in sho

[PATCH v2 3/4] t4203: test mailmap functionality directly rather than indirectly

2013-07-11 Thread Eric Sunshine
With the introduction of check-mailmap, it is now possible to check .mailmap functionality directly rather than indirectly as a side-effect of other commands (such as git-shortlog), therefore, do so. Signed-off-by: Eric Sunshine --- t/t4203-mailmap.sh | 133 ++