Re: [PATCH v2 3/4] diff: add flag to indicate textconv was set via cmdline

2017-10-30 Thread Junio C Hamano
Brandon Williams writes: > diff --git a/builtin/log.c b/builtin/log.c > index dc28d43eb..82131751d 100644 > --- a/builtin/log.c > +++ b/builtin/log.c > @@ -485,7 +485,7 @@ static int show_blob_object(const struct object_id *oid, > struct rev_info *rev, c > unsigned long size; > > f

Re: [PATCH v2 3/4] diff: add flag to indicate textconv was set via cmdline

2017-10-30 Thread Brandon Williams
On 10/30, Brandon Williams wrote: > On 10/30, Stefan Beller wrote: > > On Mon, Oct 30, 2017 at 12:46 PM, Brandon Williams > > wrote: > > > git-show is unique in that it wants to use textconv by default except > > > for when it is showing blobs. When asked to show a blob, show doesn't > > > want

Re: [PATCH v2 3/4] diff: add flag to indicate textconv was set via cmdline

2017-10-30 Thread Brandon Williams
On 10/30, Stefan Beller wrote: > On Mon, Oct 30, 2017 at 12:46 PM, Brandon Williams wrote: > > git-show is unique in that it wants to use textconv by default except > > for when it is showing blobs. When asked to show a blob, show doesn't > > want to use textconv unless the user explicitly reques

Re: [PATCH v2 3/4] diff: add flag to indicate textconv was set via cmdline

2017-10-30 Thread Stefan Beller
On Mon, Oct 30, 2017 at 12:46 PM, Brandon Williams wrote: > git-show is unique in that it wants to use textconv by default except > for when it is showing blobs. When asked to show a blob, show doesn't > want to use textconv unless the user explicitly requested that it be > used by providing the

[PATCH v2 3/4] diff: add flag to indicate textconv was set via cmdline

2017-10-30 Thread Brandon Williams
git-show is unique in that it wants to use textconv by default except for when it is showing blobs. When asked to show a blob, show doesn't want to use textconv unless the user explicitly requested that it be used by providing the command line flag '--textconv'. Currently this is done by using a