Re: [PATCH v2 3/3] diff: turn skip_stat_unmatch on selectively

2014-01-31 Thread Junio C Hamano
Duy Nguyen writes: > On Thu, Jan 30, 2014 at 2:25 AM, Junio C Hamano wrote: >>> On Tue, Jan 28, 2014 at 02:51:45PM -0800, Junio C Hamano wrote: >> This however shows that the existing test *KNEW* that it was enough >> to check just a few cases (especially, there is no reason to make >> sure that

Re: [PATCH v2 3/3] diff: turn skip_stat_unmatch on selectively

2014-01-29 Thread Duy Nguyen
On Thu, Jan 30, 2014 at 2:25 AM, Junio C Hamano wrote: >> On Tue, Jan 28, 2014 at 02:51:45PM -0800, Junio C Hamano wrote: > This however shows that the existing test *KNEW* that it was enough > to check just a few cases (especially, there is no reason to make > sure that blob vs file-in-working-tr

Re: [PATCH v2 3/3] diff: turn skip_stat_unmatch on selectively

2014-01-29 Thread Junio C Hamano
Duy Nguyen writes: > On Tue, Jan 28, 2014 at 02:51:45PM -0800, Junio C Hamano wrote: >> >> This replaces 'diff: turn off skip_stat_unmatch on "diff --cached"' >> >> The previous patch obviously leaves skip_stat_unmatch on in "diff >> >> " and maybe other cases. >> > >> > Oops, I lost track.

Re: [PATCH v2 3/3] diff: turn skip_stat_unmatch on selectively

2014-01-28 Thread Duy Nguyen
On Tue, Jan 28, 2014 at 02:51:45PM -0800, Junio C Hamano wrote: > >> This replaces 'diff: turn off skip_stat_unmatch on "diff --cached"' > >> The previous patch obviously leaves skip_stat_unmatch on in "diff > >> " and maybe other cases. > > > > Oops, I lost track. Sorry. > > Together with {1

Re: [PATCH v2 3/3] diff: turn skip_stat_unmatch on selectively

2014-01-28 Thread Junio C Hamano
Junio C Hamano writes: > Nguyễn Thái Ngọc Duy writes: > >> skip_stat_unmatch flag is added in fb13227 (git-diff: squelch "empty" >> diffs - 2007-08-03) to ignore empty diffs caused by stat-only >> dirtiness. In some diff case, stat is not involved at all. While >> the code is written in a way t

Re: [PATCH v2 3/3] diff: turn skip_stat_unmatch on selectively

2014-01-27 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > skip_stat_unmatch flag is added in fb13227 (git-diff: squelch "empty" > diffs - 2007-08-03) to ignore empty diffs caused by stat-only > dirtiness. In some diff case, stat is not involved at all. While > the code is written in a way that no expensive I/O is done, we

[PATCH v2 3/3] diff: turn skip_stat_unmatch on selectively

2014-01-27 Thread Nguyễn Thái Ngọc Duy
skip_stat_unmatch flag is added in fb13227 (git-diff: squelch "empty" diffs - 2007-08-03) to ignore empty diffs caused by stat-only dirtiness. In some diff case, stat is not involved at all. While the code is written in a way that no expensive I/O is done, we still need to move all file pairs from