Re: [PATCH v2 21/25] fetch: define shallow boundary with --shallow-exclude

2016-02-18 Thread Eric Sunshine
On Mon, Feb 15, 2016 at 3:15 AM, Duy Nguyen wrote: > On Mon, Feb 15, 2016 at 12:52:26AM -0500, Eric Sunshine wrote: >> Yes, dropping 'const' was implied. I didn't examine it too deeply, but >> it did not appear as if there would be any major fallout from dropping >> 'const'. It feels a bit cleaner

Re: [PATCH v2 21/25] fetch: define shallow boundary with --shallow-exclude

2016-02-15 Thread Duy Nguyen
On Mon, Feb 15, 2016 at 12:52:26AM -0500, Eric Sunshine wrote: > Yes, dropping 'const' was implied. I didn't examine it too deeply, but > it did not appear as if there would be any major fallout from dropping > 'const'. It feels a bit cleaner to keep it all self-contained than to > have that somewh

Re: [PATCH v2 21/25] fetch: define shallow boundary with --shallow-exclude

2016-02-14 Thread Eric Sunshine
On Mon, Feb 15, 2016 at 12:52 AM, Eric Sunshine wrote: > On Sun, Feb 14, 2016 at 10:53 PM, Duy Nguyen wrote: >> On Fri, Feb 5, 2016 at 12:26 PM, Eric Sunshine >> wrote: >>> Hmm, can't this be simplified to: >>> >>> if (skip_prefix(arg, "--shallow-exclude=", &value)) { >>> if (!args.

Re: [PATCH v2 21/25] fetch: define shallow boundary with --shallow-exclude

2016-02-14 Thread Eric Sunshine
On Sun, Feb 14, 2016 at 10:53 PM, Duy Nguyen wrote: > On Fri, Feb 5, 2016 at 12:26 PM, Eric Sunshine > wrote: >> On Thu, Feb 4, 2016 at 4:03 AM, Nguyễn Thái Ngọc Duy >> wrote: >>> Signed-off-by: Nguyễn Thái Ngọc Duy >>> --- >>> diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c >>> @@ -

Re: [PATCH v2 21/25] fetch: define shallow boundary with --shallow-exclude

2016-02-14 Thread Duy Nguyen
On Fri, Feb 5, 2016 at 12:26 PM, Eric Sunshine wrote: > On Thu, Feb 4, 2016 at 4:03 AM, Nguyễn Thái Ngọc Duy > wrote: >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- >> diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c >> @@ -109,6 +109,16 @@ int cmd_fetch_pack(int argc, const char **argv,

Re: [PATCH v2 21/25] fetch: define shallow boundary with --shallow-exclude

2016-02-04 Thread Eric Sunshine
On Thu, Feb 4, 2016 at 4:03 AM, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c > @@ -109,6 +109,16 @@ int cmd_fetch_pack(int argc, const char **argv, const > char *prefix) > + if (skip_prefix(arg, "

[PATCH v2 21/25] fetch: define shallow boundary with --shallow-exclude

2016-02-04 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- Documentation/fetch-options.txt | 5 + Documentation/git-fetch-pack.txt| 5 + Documentation/gitremote-helpers.txt | 4 builtin/fetch-pack.c| 10 ++ builtin/fetch.c | 17 - f