Re: [PATCH v2 20/29] grep: remove redundant `regflags &= ~REG_EXTENDED` assignments

2017-05-15 Thread Ævar Arnfjörð Bjarmason
On Mon, May 15, 2017 at 8:14 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Remove redundant assignments to the "regflags" variable. There are no >> code paths that have previously set the regflags to anything, and >> certainly not to `|= REG_EXTENDED`. >> >> This code gave the

Re: [PATCH v2 20/29] grep: remove redundant `regflags &= ~REG_EXTENDED` assignments

2017-05-14 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Remove redundant assignments to the "regflags" variable. There are no > code paths that have previously set the regflags to anything, and > certainly not to `|= REG_EXTENDED`. > > This code gave the impression that it had to reset its environment, > but it doesn

[PATCH v2 20/29] grep: remove redundant `regflags &= ~REG_EXTENDED` assignments

2017-05-13 Thread Ævar Arnfjörð Bjarmason
Remove redundant assignments to the "regflags" variable. There are no code paths that have previously set the regflags to anything, and certainly not to `|= REG_EXTENDED`. This code gave the impression that it had to reset its environment, but it doesn't. This dates back to the initial introductio