Re: [PATCH v2 2/8] alloc: write out allocator definitions

2014-07-15 Thread Junio C Hamano
Jeff King writes: > Because the allocator functions for tree, blobs, etc are all > very similar, we originally used a macro to avoid repeating > ourselves. Since the prior commit, though, the heavy lifting > is done by an inline helper function. The macro does still > save us a few lines, but at

[PATCH v2 2/8] alloc: write out allocator definitions

2014-07-12 Thread Jeff King
Because the allocator functions for tree, blobs, etc are all very similar, we originally used a macro to avoid repeating ourselves. Since the prior commit, though, the heavy lifting is done by an inline helper function. The macro does still save us a few lines, but at some readability cost. It ob