On Fri, Jun 27, 2014 at 1:09 AM, Junio C Hamano wrote:
> Nguyễn Thái Ngọc Duy writes:
>
>> fsck is a tool that error() is more preferred than die(), but many
>
> "more preferred" without justifying why it is "more preferred" is
> not quite a justification, is it? Also, an object failing to load
Nguyễn Thái Ngọc Duy writes:
> fsck is a tool that error() is more preferred than die(), but many
"more preferred" without justifying why it is "more preferred" is
not quite a justification, is it? Also, an object failing to load
in-core is not a missing object, so if your aim is to let "fsck"
fsck is a tool that error() is more preferred than die(), but many
functions embed die() inside beyond fsck's control.
unpack_compressed_entry()'s using xmallocz is such a function,
triggered from verify_packfile() -> unpack_entry(). Make it use
xmallocz_gentle() instead.
Noticed-by: Dale R. Worle
3 matches
Mail list logo
