Re: [PATCH v2 2/4] format-patch: add '--base' option to record base tree info

2016-03-23 Thread Ye Xiaolong
On Wed, Mar 23, 2016 at 11:08:20AM -0700, Junio C Hamano wrote: >Xiaolong Ye writes: > >Reviewing the patch out of order, caller first and then callee. > >> +static void print_bases(struct base_tree_info *bases) >> +{ >> +int i; >> + >> +/* Only do this once, either for the cover or for th

Re: [PATCH v2 2/4] format-patch: add '--base' option to record base tree info

2016-03-23 Thread Junio C Hamano
Xiaolong Ye writes: Reviewing the patch out of order, caller first and then callee. > +static void print_bases(struct base_tree_info *bases) > +{ > + int i; > + > + /* Only do this once, either for the cover or for the first one */ > + if (is_null_oid(&bases->base_commit)) > +

[PATCH v2 2/4] format-patch: add '--base' option to record base tree info

2016-03-23 Thread Xiaolong Ye
Maintainers or third party testers may want to know the exact base tree the patch series applies to. Teach git format-patch a '--base' option to record the base tree info and append this information at the end of the _first_ message (either the cover letter or the first patch in the series). Signe