Jeff King writes:
> Overall, it looks good for me except for the commit message tweaks I
> mentioned above.
Thanks. Rerolled; will resend when I have time (and if I do not
forget).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kerne
On Mon, Jun 10, 2013 at 04:23:31PM -0700, Junio C Hamano wrote:
> OK, I pushed out a result of some renaming and rebasing. Notable
> changes are:
>
> - The data and API is called prio-queue and they live in prio-queue.[ch];
>
> - The test script is also named test-prio-queue.c, to leave the
>
Jeff King writes:
> On Mon, Jun 10, 2013 at 11:56:33AM -0700, Junio C Hamano wrote:
>
>> > or similar. I didn't change the name, either. It may be silly to call it
>> > "commit_queue" still since it is now more general. I simply called mine
>> > "queue" (I wanted "pqueue", but that conflicted wit
On Mon, Jun 10, 2013 at 11:56:33AM -0700, Junio C Hamano wrote:
> > or similar. I didn't change the name, either. It may be silly to call it
> > "commit_queue" still since it is now more general. I simply called mine
> > "queue" (I wanted "pqueue", but that conflicted with globals defined by
> > O
Jeff King writes:
> On Mon, Jun 10, 2013 at 12:21:00AM -0700, Junio C Hamano wrote:
>
>> > It may be worth looking again for other places to use this over
>> > commit_list, but even the caller you are introducing here justifies its
>> > presence.
>>
>> The next candidate is paint-down-to-common,
On Mon, Jun 10, 2013 at 12:21:00AM -0700, Junio C Hamano wrote:
> > It may be worth looking again for other places to use this over
> > commit_list, but even the caller you are introducing here justifies its
> > presence.
>
> The next candidate is paint-down-to-common, probably.
Yeah, I don't th
Jeff King writes:
> It may be worth looking again for other places to use this over
> commit_list, but even the caller you are introducing here justifies its
> presence.
The next candidate is paint-down-to-common, probably.
> Also, I wrote some basic tests to cover the priority queue as a unit.
On Sun, Jun 09, 2013 at 04:24:35PM -0700, Junio C Hamano wrote:
> Traditionally we used a singly linked list of commits to hold a set
> of in-flight commits while traversing history. The most typical use
> of the list is to add commits that are newly discovered to it, keep
> the list sorted by co
Traditionally we used a singly linked list of commits to hold a set
of in-flight commits while traversing history. The most typical use
of the list is to add commits that are newly discovered to it, keep
the list sorted by commit timestamp, pick up the newest one from the
list, and keep digging.
9 matches
Mail list logo
