Re: [PATCH v2 2/3] upload-pack: read config when serving protocol v2

2018-05-03 Thread Jonathan Tan
On Thu, 3 May 2018 12:08:16 -0700 Stefan Beller wrote: > test_path_is_missing ? Thanks for the pointer. Done. > > + GIT_TRACE=/tmp/y git -c protocol.version=2 clone > > "file://$(pwd)/server" client && > > Why do we redirect GIT_TRACE outside the test suite? do we read that > back or wa

Re: [PATCH v2 2/3] upload-pack: read config when serving protocol v2

2018-05-03 Thread Stefan Beller
On Tue, May 1, 2018 at 5:31 PM, Jonathan Tan wrote: > The upload-pack code paths never call git_config() with > upload_pack_config() when protocol v2 is used, causing options like > uploadpack.packobjectshook to not take effect. Ensure that this function > is called. > > Signed-off-by: Jonathan Ta

[PATCH v2 2/3] upload-pack: read config when serving protocol v2

2018-05-01 Thread Jonathan Tan
The upload-pack code paths never call git_config() with upload_pack_config() when protocol v2 is used, causing options like uploadpack.packobjectshook to not take effect. Ensure that this function is called. Signed-off-by: Jonathan Tan --- t/t5702-protocol-v2.sh | 14 ++ upload-pack.