Re: [PATCH v2 2/3] add -p: allow line selection to be inverted

2018-03-14 Thread Phillip Wood
On 13/03/18 16:32, Junio C Hamano wrote: > Phillip Wood writes: > >> On 08/03/18 17:53, Junio C Hamano wrote: >>> Phillip Wood writes: >>> and use a leading '-' for inversion. I'm tempted to keep supporting 'n-' to mean everything from 'n' to the last line though. >>> >>> Thanks for do

Re: [PATCH v2 2/3] add -p: allow line selection to be inverted

2018-03-13 Thread Junio C Hamano
Phillip Wood writes: > On 08/03/18 17:53, Junio C Hamano wrote: >> Phillip Wood writes: >> >>> and use a leading '-' for inversion. I'm tempted to keep supporting 'n-' >>> to mean everything from 'n' to the last line though. >> >> Thanks for double checking. It would be a better endgame to fo

Re: [PATCH v2 2/3] add -p: allow line selection to be inverted

2018-03-13 Thread Phillip Wood
On 08/03/18 17:53, Junio C Hamano wrote: > Phillip Wood writes: > >> and use a leading '-' for inversion. I'm tempted to keep supporting 'n-' >> to mean everything from 'n' to the last line though. > > Thanks for double checking. It would be a better endgame to follow > up with an update to exi

Re: [PATCH v2 2/3] add -p: allow line selection to be inverted

2018-03-08 Thread Junio C Hamano
Phillip Wood writes: > and use a leading '-' for inversion. I'm tempted to keep supporting 'n-' > to mean everything from 'n' to the last line though. Thanks for double checking. It would be a better endgame to follow up with an update to existing "range selection" code to also support "n-", if

Re: [PATCH v2 2/3] add -p: allow line selection to be inverted

2018-03-08 Thread Phillip Wood
On 06/03/18 19:57, Junio C Hamano wrote: > Phillip Wood writes: > >> From: Phillip Wood >> >> If the list of lines to be selected begins with '^' select all the >> lines except the ones listed. > > There is "# Input that begins with '-'; unchoose" in list_and_choose > helper. Does it make thin

Re: [PATCH v2 2/3] add -p: allow line selection to be inverted

2018-03-06 Thread Igor Djordjevic
On 06/03/2018 11:17, Phillip Wood wrote: > From: Phillip Wood > > If the list of lines to be selected begins with '^' select all the > lines except the ones listed. s/to be selected begins with '^' select all/to be staged begins with '^' stage all/ > > Signed-off-by: Phillip Wood > --- > Do

Re: [PATCH v2 2/3] add -p: allow line selection to be inverted

2018-03-06 Thread Junio C Hamano
Phillip Wood writes: > From: Phillip Wood > > If the list of lines to be selected begins with '^' select all the > lines except the ones listed. There is "# Input that begins with '-'; unchoose" in list_and_choose helper. Does it make things inconsistent to use '^' for negation like this patch

[PATCH v2 2/3] add -p: allow line selection to be inverted

2018-03-06 Thread Phillip Wood
From: Phillip Wood If the list of lines to be selected begins with '^' select all the lines except the ones listed. Signed-off-by: Phillip Wood --- Documentation/git-add.txt | 3 ++- git-add--interactive.perl | 17 - t/t3701-add-interactive.sh | 2 +- 3 files changed, 19 in