Re: [msysGit] [PATCH v2 10/16] engine.pl: delete the captured stderr file if empty

2015-07-20 Thread Eric Sunshine
On Mon, Jul 20, 2015 at 7:55 AM, Philip Oakley wrote: > From: "Eric Sunshine" >> Although that works, I'm not sure that it's really all that desirable >> due to the unnecessary and potentially confusing 'for' loop. I'd >> probably just write it as: >> >>unlink $ErrsFile if -f $ErrsFile && !-s

Re: [msysGit] [PATCH v2 10/16] engine.pl: delete the captured stderr file if empty

2015-07-20 Thread Philip Oakley
From: "Eric Sunshine" On Mon, Jul 20, 2015 at 2:16 AM, Philip Oakley wrote: From: "Eric Sunshine" On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley wrote: Keep the build clean of extraneous files if it is indeed clean. Otherwise leave the msvc-build-makedryerrors.txt file both as a flag for a

Re: [msysGit] [PATCH v2 10/16] engine.pl: delete the captured stderr file if empty

2015-07-19 Thread Eric Sunshine
On Mon, Jul 20, 2015 at 2:16 AM, Philip Oakley wrote: > From: "Eric Sunshine" >> On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley >> wrote: >>> Keep the build clean of extraneous files if it is indeed clean. >>> Otherwise leave the msvc-build-makedryerrors.txt file both as >>> a flag for any CI sy

Re: [msysGit] [PATCH v2 10/16] engine.pl: delete the captured stderr file if empty

2015-07-19 Thread Philip Oakley
From: "Eric Sunshine" On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley wrote: Keep the build clean of extraneous files if it is indeed clean. Otherwise leave the msvc-build-makedryerrors.txt file both as a flag for any CI system or for manual debugging. Note that the file will contain the new v

Re: [msysGit] [PATCH v2 10/16] engine.pl: delete the captured stderr file if empty

2015-07-19 Thread Eric Sunshine
On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley wrote: > Keep the build clean of extraneous files if it is indeed clean. > Otherwise leave the msvc-build-makedryerrors.txt file both as > a flag for any CI system or for manual debugging. > > Note that the file will contain the new values of the GIT_

[PATCH v2 10/16] engine.pl: delete the captured stderr file if empty

2015-07-19 Thread Philip Oakley
Keep the build clean of extraneous files if it is indeed clean. Otherwise leave the msvc-build-makedryerrors.txt file both as a flag for any CI system or for manual debugging. Note that the file will contain the new values of the GIT_VERSION and GITGUI_VERSION if they were generated by the make fi