Re: [PATCH v2 10/11] test-lib: make it possible to override how test code is eval'd

2014-06-06 Thread Junio C Hamano
Richard Hansen writes: > On 2014-06-05 17:11, Junio C Hamano wrote: > ... >> In any case, the above explanation confuses me somewhat. test_eval_ >> is fed a scriptlet defined for various test_expect_success tests, >> and they are written in POSIX shells, not zsh, so wouldn't it be >> wrong to ru

Re: [PATCH v2 10/11] test-lib: make it possible to override how test code is eval'd

2014-06-05 Thread Richard Hansen
On 2014-06-05 17:11, Junio C Hamano wrote: > Richard Hansen writes: > >> Because test_eval_ is defined while zsh is in sh emulation mode, the >> shell code passed as an argument to test_expect_success would normally >> be evaluated in sh emulation mode. However, with this change, it is >> now po

Re: [PATCH v2 10/11] test-lib: make it possible to override how test code is eval'd

2014-06-05 Thread Junio C Hamano
Richard Hansen writes: > Because test_eval_ is defined while zsh is in sh emulation mode, the > shell code passed as an argument to test_expect_success would normally > be evaluated in sh emulation mode. However, with this change, it is > now possible to evaluate the test code in zsh mode by add

[PATCH v2 10/11] test-lib: make it possible to override how test code is eval'd

2014-06-04 Thread Richard Hansen
If a command named 'test_eval_override' exists, use it instead of 'eval' to run the test code. This is needed to support zsh test cases: test-lib.sh must be sourced in sh emulation mode due to fundamental incompatibilities between the POSIX sh language and the zsh language. When a function is de