Re: [PATCH v2 10/10] git.c: ignore pager.* when launching builtin as dashed external

2017-07-31 Thread Martin Ågren
On 31 July 2017 at 05:45, Jeff King wrote: > On Mon, Jul 17, 2017 at 10:10:52PM +0200, Martin Ågren wrote: > >> One could address this in run_argv(), by making the second call to >> execv_dashed_external() conditional on "!is_builtin()" whereas a builtin >> would be started as "git foo". (Possibly

Re: [PATCH v2 10/10] git.c: ignore pager.* when launching builtin as dashed external

2017-07-30 Thread Jeff King
On Mon, Jul 17, 2017 at 10:10:52PM +0200, Martin Ågren wrote: > When running, e.g., `git -c alias.bar=foo bar`, we expand the alias and > execute `git-foo` as a dashed external. This is true even if git foo is > a builtin. That is on purpose, and is motivated in a comment which was > added in comm

[PATCH v2 10/10] git.c: ignore pager.* when launching builtin as dashed external

2017-07-17 Thread Martin Ågren
When running, e.g., `git -c alias.bar=foo bar`, we expand the alias and execute `git-foo` as a dashed external. This is true even if git foo is a builtin. That is on purpose, and is motivated in a comment which was added in commit 441981bc ("git: simplify environment save/restore logic", 2016-01-26